From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 24 Aug 2020 13:58:16 +0000 (+0300)
Subject: imap: Fix crash if imap-hibernate socket can't be connected to
X-Git-Tag: 2.3.14.rc1~192
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=73937b5fe7eb1dde76f30ef6b181c920bbbc4558;p=thirdparty%2Fdovecot%2Fcore.git

imap: Fix crash if imap-hibernate socket can't be connected to

The error was supposed to be returned to caller, not logged directly.
---

diff --git a/src/imap/imap-client-hibernate.c b/src/imap/imap-client-hibernate.c
index 4ef323453c..d3451b1bf6 100644
--- a/src/imap/imap-client-hibernate.c
+++ b/src/imap/imap-client-hibernate.c
@@ -176,7 +176,8 @@ imap_hibernate_process_send(struct client *client, const buffer_t *state,
 			   "/"IMAP_HIBERNATE_SOCKET_NAME, NULL);
 	fd = net_connect_unix_with_retries(path, 1000);
 	if (fd == -1) {
-		e_error(client->event, "net_connect_unix(%s) failed: %m", path);
+		*error_r = t_strdup_printf(
+			"net_connect_unix(%s) failed: %m", path);
 		return -1;
 	}
 	net_set_nonblock(fd, FALSE);