From: William Lallemand <wlallemand@haproxy.org>
Date: Tue, 28 Sep 2021 08:10:07 +0000 (+0200)
Subject: MINOR: httpclient: set HTTPCLIENT_F_ENDED only in release
X-Git-Tag: v2.5-dev9~120
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=739f90a6ef4168a6ec76fb7e68948820815c8e6c;p=thirdparty%2Fhaproxy.git

MINOR: httpclient: set HTTPCLIENT_F_ENDED only in release

Only set the HTTPCLIENT_F_ENDED flag in httpclient_applet_release()
function so we are sure that the appctx is not used anymore once the
flag is set.
---

diff --git a/src/http_client.c b/src/http_client.c
index 9e5b2e8311..3ea86c21e5 100644
--- a/src/http_client.c
+++ b/src/http_client.c
@@ -578,7 +578,6 @@ static void httpclient_applet_io_handler(struct appctx *appctx)
 					 * set, leave (no body) */
 					if (htx_is_empty(htx) && htx->flags & HTX_FL_EOM) {
 						appctx->st0 = HTTPCLIENT_S_RES_END;
-						hc->flags |= HTTPCLIENT_F_ENDED;
 					} else {
 						appctx->st0 = HTTPCLIENT_S_RES_BODY;
 					}