From: Namjae Jeon <namjae.jeon@samsung.com>
Date: Wed, 26 May 2021 06:53:26 +0000 (+0900)
Subject: cifsd: change success handling to failure handling
X-Git-Tag: v5.15-rc1~183^2~18^2~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=73b8b08539423a888ed76b53401a6366e0e2af2b;p=thirdparty%2Fkernel%2Flinux.git

cifsd: change success handling to failure handling

Change success handling to failure handling in ksmbd_crypt_message().

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/cifsd/auth.c b/fs/cifsd/auth.c
index 5a56dd65fa06f..b0a9e4591fa55 100644
--- a/fs/cifsd/auth.c
+++ b/fs/cifsd/auth.c
@@ -1331,9 +1331,13 @@ int ksmbd_crypt_message(struct ksmbd_conn *conn, struct kvec *iov,
 		rc = crypto_aead_encrypt(req);
 	else
 		rc = crypto_aead_decrypt(req);
-	if (!rc && enc)
+	if (rc)
+		goto free_iv;
+
+	if (enc)
 		memcpy(&tr_hdr->Signature, sign, SMB2_SIGNATURE_SIZE);
 
+free_iv:
 	kfree(iv);
 free_sg:
 	kfree(sg);