From: Eric Sunshine Date: Fri, 29 Mar 2024 22:27:03 +0000 (-0400) Subject: test-lib: fix non-functioning GIT_TEST_MAINT_SCHEDULER fallback X-Git-Tag: v2.45.0-rc0~39^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=73cb87773b6dd4818d0bf485f53a43baeda88145;p=thirdparty%2Fgit.git test-lib: fix non-functioning GIT_TEST_MAINT_SCHEDULER fallback When environment variable GIT_TEST_MAINT_SCHEDULER is set, `git maintenance` invokes the command specified as the variable's value rather than invoking the actual underlying platform-specific scheduler management command. By setting GIT_TEST_MAINT_SCHEDULER to some suitable value, test authors can therefore validate behavior of "destructive" `git maintenance` commands without having to worry about clobbering the user's own local scheduler configuration. In order to protect an absent-minded test author from forgetting to set GIT_TEST_MAINT_SCHEDULER in the local test script (and thus clobbering his or her own scheduler configuration), t/test-lib.sh assigns an "immediately error-out" value to GIT_TEST_MAINT_SCHEDULER by default which should ensure that the problem will be caught and reported before any damage can be done to the configuration of the person running the tests. Unfortunately, however, t/test-lib.sh neglects to export GIT_TEST_MAINT_SCHEDULER, which renders the default "error-out" assignment worthless. Fix this by exporting the variable as originally intended. Reported-by: Junio C Hamano Signed-of-by: Eric Sunshine Signed-off-by: Junio C Hamano --- diff --git a/t/test-lib.sh b/t/test-lib.sh index 62136caee5..46e5c86f04 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1937,6 +1937,7 @@ test_lazy_prereq SHA1 ' # Tests that verify the scheduler integration must set this locally # to avoid errors. GIT_TEST_MAINT_SCHEDULER="none:exit 1" +export GIT_TEST_MAINT_SCHEDULER # Does this platform support `git fsmonitor--daemon` #