From: Andrew Dunstan <andrew@dunslane.net>
Date: Sun, 26 Feb 2023 11:48:41 +0000 (-0500)
Subject: Don't force SQL_ASCII/no-locale for installcheck in vcregress.pl
X-Git-Tag: REL_11_20~59
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=73e779b3807dedb9b0bc20d4ce12a350033aa646;p=thirdparty%2Fpostgresql.git

Don't force SQL_ASCII/no-locale for installcheck in vcregress.pl

It's been this way for a very long time, but it appears to have been
masking an issue that only manifests with different settings. Therefore,
run the tests in the installation's default encoding/locale.

Backpatch to all live branches.
---

diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
index 34de9e1576e..bc994e8ac74 100644
--- a/src/tools/msvc/vcregress.pl
+++ b/src/tools/msvc/vcregress.pl
@@ -150,9 +150,7 @@ sub installcheck_internal
 		"--dlpath=.",
 		"--bindir=../../../$Config/psql",
 		"--schedule=${schedule}_schedule",
-		"--max-concurrent-tests=20",
-		"--encoding=SQL_ASCII",
-		"--no-locale");
+		"--max-concurrent-tests=20");
 	push(@args, $maxconn) if $maxconn;
 	push(@args, @EXTRA_REGRESS_OPTS);
 	system(@args);