From: Lad Prabhakar Date: Wed, 20 Aug 2025 20:23:22 +0000 (+0100) Subject: watchdog: rzv2h: Improve error strings and add newlines X-Git-Tag: v6.18-rc1~59^2~11 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=73ea1e92be46671d9a139578fdf5f6b93b7e85e4;p=thirdparty%2Fkernel%2Fstable.git watchdog: rzv2h: Improve error strings and add newlines Update rzv2h_wdt_probe() to provide clearer error strings when retrieving the pclk, oscclk, and reset controller, and append missing newline characters to dev_err_probe() and dev_warn() calls for proper log formatting. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck --- diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c index ee3ed5a6d98e..2027795f212e 100644 --- a/drivers/watchdog/rzv2h_wdt.c +++ b/drivers/watchdog/rzv2h_wdt.c @@ -296,16 +296,16 @@ static int rzv2h_wdt_probe(struct platform_device *pdev) priv->pclk = devm_clk_get_prepared(dev, "pclk"); if (IS_ERR(priv->pclk)) - return dev_err_probe(dev, PTR_ERR(priv->pclk), "no pclk"); + return dev_err_probe(dev, PTR_ERR(priv->pclk), "Failed to get pclk\n"); priv->oscclk = devm_clk_get_optional_prepared(dev, "oscclk"); if (IS_ERR(priv->oscclk)) - return dev_err_probe(dev, PTR_ERR(priv->oscclk), "no oscclk"); + return dev_err_probe(dev, PTR_ERR(priv->oscclk), "Failed to get oscclk\n"); priv->rstc = devm_reset_control_get_optional_exclusive(dev, NULL); if (IS_ERR(priv->rstc)) return dev_err_probe(dev, PTR_ERR(priv->rstc), - "failed to get cpg reset"); + "Failed to get cpg reset\n"); switch (priv->of_data->count_source) { case COUNT_SOURCE_LOCO: @@ -343,7 +343,7 @@ static int rzv2h_wdt_probe(struct platform_device *pdev) ret = watchdog_init_timeout(&priv->wdev, 0, dev); if (ret) - dev_warn(dev, "Specified timeout invalid, using default"); + dev_warn(dev, "Specified timeout invalid, using default\n"); return devm_watchdog_register_device(dev, &priv->wdev); }