From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 11 Oct 2021 12:40:05 +0000 (+0300)
Subject: drm/msm: unlock on error in get_sched_entity()
X-Git-Tag: v5.16-rc1~140^2~2^2~20
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7425e8167507fe512d8ac0825acda4aebf0a7ca0;p=thirdparty%2Fkernel%2Flinux.git

drm/msm: unlock on error in get_sched_entity()

Add a missing unlock on the error path if drm_sched_entity_init() fails.

Fixes: 68002469e571 ("drm/msm: One sched entity per process per priority")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211011124005.GE15188@kili
Signed-off-by: Rob Clark <robdclark@chromium.org>
---

diff --git a/drivers/gpu/drm/msm/msm_submitqueue.c b/drivers/gpu/drm/msm/msm_submitqueue.c
index b8621c6e05546..7cb158bcbcf67 100644
--- a/drivers/gpu/drm/msm/msm_submitqueue.c
+++ b/drivers/gpu/drm/msm/msm_submitqueue.c
@@ -101,6 +101,7 @@ get_sched_entity(struct msm_file_private *ctx, struct msm_ringbuffer *ring,
 
 		ret = drm_sched_entity_init(entity, sched_prio, &sched, 1, NULL);
 		if (ret) {
+			mutex_unlock(&entity_lock);
 			kfree(entity);
 			return ERR_PTR(ret);
 		}