From: Nikita <32056979+Roo4L@users.noreply.github.com>
Date: Fri, 13 Aug 2021 21:50:07 +0000 (+0000)
Subject: ext_lm_group_acl: Improved username handling (#884)
X-Git-Tag: SQUID_6_0_1~299
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=742d042ea820b4ecac2a651a889e0c37f327618e;p=thirdparty%2Fsquid.git

ext_lm_group_acl: Improved username handling (#884)

Ensure that NTDomain is terminated even if UserName is long.
It happened to be terminated in the current code, but only by accident.
---

diff --git a/src/acl/external/LM_group/ext_lm_group_acl.cc b/src/acl/external/LM_group/ext_lm_group_acl.cc
index 30490e2a77..c6ca3fcaee 100644
--- a/src/acl/external/LM_group/ext_lm_group_acl.cc
+++ b/src/acl/external/LM_group/ext_lm_group_acl.cc
@@ -336,7 +336,7 @@ Valid_Global_Groups(char *UserName, const char **Groups)
     DWORD i;
     DWORD dwTotalCount = 0;
 
-    strncpy(NTDomain, UserName, sizeof(NTDomain));
+    xstrncpy(NTDomain, UserName, sizeof(NTDomain));
 
     for (j = 0; j < strlen(NTV_VALID_DOMAIN_SEPARATOR); ++j) {
         if ((domain_qualify = strchr(NTDomain, NTV_VALID_DOMAIN_SEPARATOR[j])) != NULL)