From: Boris Brezillon <boris.brezillon@collabora.com>
Date: Wed, 9 Aug 2023 11:31:08 +0000 (+0200)
Subject: PM / devfreq: Fix leak in devfreq_dev_release()
X-Git-Tag: v4.14.326~85
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7462483446cb9986568ad7adae746ce5f18d2968;p=thirdparty%2Fkernel%2Fstable.git

PM / devfreq: Fix leak in devfreq_dev_release()

commit 5693d077595de721f9ddbf9d37f40e5409707dfe upstream.

srcu_init_notifier_head() allocates resources that need to be released
with a srcu_cleanup_notifier_head() call.

Reported by kmemleak.

Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index b05e6a15221c9..e6674448a0bc3 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -495,6 +495,7 @@ static void devfreq_dev_release(struct device *dev)
 		devfreq->profile->exit(devfreq->dev.parent);
 
 	mutex_destroy(&devfreq->lock);
+	srcu_cleanup_notifier_head(&devfreq->transition_notifier_list);
 	kfree(devfreq);
 }