From: Eric Wong <e@80x24.org>
Date: Mon, 10 Nov 2025 03:47:08 +0000 (+0000)
Subject: t/pop3d: try fixing "APOP UUID\@$mailbox w/ STLS" test
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7491a0fe540480acfbe479c86faa59bbb48c0678;p=thirdparty%2Fpublic-inbox.git

t/pop3d: try fixing "APOP UUID\@$mailbox w/ STLS" test

I would've thought the ping-ponging of making a new POP3
connection and enabling STARTTLS was enough to trigger the
previous connection to close and unlock the maildrop.  In most
test runs, that appeared sufficient, but occasional failures
still happened.

The diagnostics added a few weeks ago reveals a
"[IN-USE] unable to lock maildrop" message seen by Net::POP3,
so lets try calling Net::POP3->quit on the client to explicitly
trigger ->unlock_mailbox on the server side and hope these
occasional test failures go away.

Followup-to: f4216637 (t/pop3d: add diagnostics on APOP after STLS failure, 2025-10-22)
---

diff --git a/t/pop3d.t b/t/pop3d.t
index 10eac41c4..b69a18084 100644
--- a/t/pop3d.t
+++ b/t/pop3d.t
@@ -242,6 +242,7 @@ EOF
 			'TOP numlines=1');
 
 		$msg = $np3->top(2, 10000);
+		ok $np3->quit, 'QUIT works after TOP'; # needed for later APOP?
 		$msg = join('', @$msg);
 		$msg =~ s/\r\n/\n/g;
 		is_deeply(PublicInbox::Eml->new($msg), $patch,