From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 1 Jul 2022 10:42:51 +0000 (+0200)
Subject: clone: fix memory leak in wanted_peer_refs()
X-Git-Tag: v2.38.0-rc0~155^2~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=74a06a9f2103332d50ddc17dcd6a0a153a5e377d;p=thirdparty%2Fgit.git

clone: fix memory leak in wanted_peer_refs()

Fix a memory leak added in 0ec4b1650cc (clone: fix ref selection in
--single-branch --branch=xxx, 2012-06-22).

Whether we get our "remote_head" from copy_ref() directly, or with a
call to guess_remote_head() it'll be the result of a copy_ref() in
either case, as guess_remote_head() is a wrapper for copy_ref() (or it
returns NULL).

We can't mark any tests passing passing with SANITIZE=leak using
"TEST_PASSES_SANITIZE_LEAK=true" as a result of this change, but
e.g. "t/t1500-rev-parse.sh" now gets closer to passing.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/clone.c b/builtin/clone.c
index 89a91b0017..c43c85dad0 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -494,6 +494,7 @@ static struct ref *wanted_peer_refs(const struct ref *refs,
 			/* if --branch=tag, pull the requested tag explicitly */
 			get_fetch_map(remote_head, tag_refspec, &tail, 0);
 		}
+		free_refs(remote_head);
 	} else {
 		int i;
 		for (i = 0; i < refspec->nr; i++)