From: Willy Tarreau <w@1wt.eu>
Date: Thu, 24 Nov 2016 14:25:39 +0000 (+0100)
Subject: BUG/MINOR: cli: dequeue from the proxy when changing a maxconn
X-Git-Tag: v1.7.0~67
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=74a5a9828b7eba80248573e110bc8ed388d8b692;p=thirdparty%2Fhaproxy.git

BUG/MINOR: cli: dequeue from the proxy when changing a maxconn

The "set maxconn frontend" statement on the CLI tries to dequeue possibly
pending requests, but due to a copy-paste error, they're dequeued on the
CLI's frontend instead of the one being changed.

The impact is very minor as it only means that possibly pending connections
will still have to wait for a previous one to complete before being accepted
when a limit is raised.

This fix has to be backported to 1.6 and 1.5.
---

diff --git a/src/dumpstats.c b/src/dumpstats.c
index e22d0744c4..fe1ad48dcb 100644
--- a/src/dumpstats.c
+++ b/src/dumpstats.c
@@ -1890,8 +1890,8 @@ static int stats_sock_parse_request(struct stream_interface *si, char *line)
 						resume_listener(l);
 				}
 
-				if (px->maxconn > px->feconn && !LIST_ISEMPTY(&strm_fe(s)->listener_queue))
-					dequeue_all_listeners(&strm_fe(s)->listener_queue);
+				if (px->maxconn > px->feconn && !LIST_ISEMPTY(&px->listener_queue))
+					dequeue_all_listeners(&px->listener_queue);
 
 				return 1;
 			}