From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 1 Oct 2025 15:57:29 +0000 (+0200)
Subject: replay: stop using `the_repository`
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=74c45bfcca89600ba26566177a8408dfa1e48d75;p=thirdparty%2Fgit.git

replay: stop using `the_repository`

In `create_commit()` we're using `the_repository` even though we already
have a repository passed to use as an argument. Fix this.

Note that we still cannot get rid of `USE_THE_REPOSITORY_VARIABLE`. This
is because we use `DEFAULT_ABBREV and `get_commit_output_encoding()`,
both of which are stored as global variables that can be modified via
the Git configuration.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/replay.c b/replay.c
index e22ce39940..13d75d8054 100644
--- a/replay.c
+++ b/replay.c
@@ -62,7 +62,7 @@ static struct commit *create_commit(struct repository *repo,
 	obj = parse_object(repo, &ret);
 
 out:
-	repo_unuse_commit_buffer(the_repository, based_on, message);
+	repo_unuse_commit_buffer(repo, based_on, message);
 	free_commit_extra_headers(extra);
 	free_commit_list(parents);
 	strbuf_release(&msg);