From: drh Date: Wed, 7 Aug 2019 13:25:21 +0000 (+0000) Subject: Do not make SQLITE_READ authorizer calls for tables without names, as all X-Git-Tag: version-3.30.0~161 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=74c490e0450093c00b37d900c8ccc0ad6b4db6ba;p=thirdparty%2Fsqlite.git Do not make SQLITE_READ authorizer calls for tables without names, as all such tables will be internal-use-only tables for subqueries and whatnot. FossilOrigin-Name: 193c87fc96f964984a144c1a4506ef9db033ab2b80e64dd4d09d820fef466407 --- diff --git a/manifest b/manifest index 28f357f009..72aeed451b 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Ensure\sthat\swhen\sthe\scol\sin\san\soperator\slike\s"val\sIN(col)"\sis\sa\scolumn\sof\sa\sview,\sits\saffinity\sis\snot\sused\sto\scoerce\sval.\sFix\sfor\s[0a5e2c1d]. -D 2019-08-06T21:16:28.847 +C Do\snot\smake\sSQLITE_READ\sauthorizer\scalls\sfor\stables\swithout\snames,\sas\sall\nsuch\stables\swill\sbe\sinternal-use-only\stables\sfor\ssubqueries\sand\swhatnot. +D 2019-08-07T13:25:21.372 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724 @@ -523,7 +523,7 @@ F src/printf.c 9be6945837c839ba57837b4bc3af349eba630920fa5532aa518816defe42a7d4 F src/random.c 80f5d666f23feb3e6665a6ce04c7197212a88384 F src/resolve.c 3ed5a3de18b455366771a89241283fef16508a7f681af546296e95e81458efeb F src/rowset.c d977b011993aaea002cab3e0bb2ce50cf346000dff94e944d547b989f4b1fe93 -F src/select.c 29fd0dea774b1cc02e7451cd58dfd05f47edb7f9d20fecb7278fa94c65885d50 +F src/select.c 1c2c1d3ca6437349c5bceab29c9d3583f8fedb21ab3366d6f9d7381259af60cf F src/shell.c.in 97714cd5e177b6d53fac83c74becf4b19fe0aa8f1a4ed6a4fa1eede4bafb96f7 F src/sqlite.h.in dfe86c132b5085e00cf0539c78510b75e60d740191804c9848e8bb7aa850fff5 F src/sqlite3.rc 5121c9e10c3964d5755191c80dd1180c122fc3a8 @@ -1838,7 +1838,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0 -P 509c1ba26a4c12c63ecf04ddfa2f175eaf4dd9b96ab7be15faebd36deb0a0a31 -R 55e2d87efa132254be9293c605c02f10 -U dan -Z 0eac4d9e13db8d3c7f7c1099148e5700 +P 17b3d2218c02a4005d4c96471c452105b54abb25901ae62990b01f0c955135fe +R 7416f927830c666df23d108179a39bca +U drh +Z 25c6c6c7c7a7a6e0ba13d172e2f31a7e diff --git a/manifest.uuid b/manifest.uuid index 1276e07700..27384e9f2c 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -17b3d2218c02a4005d4c96471c452105b54abb25901ae62990b01f0c955135fe \ No newline at end of file +193c87fc96f964984a144c1a4506ef9db033ab2b80e64dd4d09d820fef466407 \ No newline at end of file diff --git a/src/select.c b/src/select.c index 1c9ac79ab0..059c6ea9ae 100644 --- a/src/select.c +++ b/src/select.c @@ -5860,7 +5860,7 @@ int sqlite3Select( ** assume the column name is non-NULL and segfault. The use of an empty ** string for the fake column name seems safer. */ - if( pItem->colUsed==0 ){ + if( pItem->colUsed==0 && pItem->zName!=0 ){ sqlite3AuthCheck(pParse, SQLITE_READ, pItem->zName, "", pItem->zDatabase); }