From: René Scharfe <l.s.r@web.de>
Date: Sun, 3 Mar 2024 10:13:26 +0000 (+0100)
Subject: t-ctype: simplify EOF check
X-Git-Tag: v2.45.0-rc0~121^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=752cb6ef816c8b2b37e38e418bd11698c00027e4;p=thirdparty%2Fgit.git

t-ctype: simplify EOF check

EOF is not a member of any character class.  If a classifier function
returns a non-zero result for it, presumably by mistake, then the unit
test check reports:

   # check "!iseof(EOF)" failed at t/unit-tests/t-ctype.c:53
   #       i: 0xffffffff (EOF)

The numeric value of EOF is not particularly interesting in this
context.  Stop printing the second line.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/unit-tests/t-ctype.c b/t/unit-tests/t-ctype.c
index 35473c41d8..f0d61d6eb2 100644
--- a/t/unit-tests/t-ctype.c
+++ b/t/unit-tests/t-ctype.c
@@ -10,8 +10,7 @@ static void test_ctype_##func(void) { \
 		if (!check_int(func(i), ==, !!memchr(string, i, len))) \
 			test_msg("       i: 0x%02x", i); \
 	} \
-	if (!check(!func(EOF))) \
-			test_msg("      i: 0x%02x (EOF)", EOF); \
+	check(!func(EOF)); \
 }
 
 #define TEST_CHAR_CLASS(class) TEST(test_ctype_##class(), #class " works")