From: Rob Herring (Arm) Date: Wed, 28 Aug 2024 13:00:54 +0000 (-0500) Subject: regulator: qcom_spmi: Drop unnecessary of_find_property() call X-Git-Tag: v6.12-rc1~190^2~25 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7540bd3398675e54cbd7324c47be8cd3c7a6d9c5;p=thirdparty%2Fkernel%2Flinux.git regulator: qcom_spmi: Drop unnecessary of_find_property() call There's no need to check for presence of "qcom,saw-reg" before parsing it. If the property doesn't exist, parsing it will return NULL. Signed-off-by: Rob Herring (Arm) Link: https://patch.msgid.link/20240828130056.3481050-1-robh@kernel.org Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 9a9fa20dcd952..68603649db48e 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -2528,8 +2528,8 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) if (!reg) return -ENODEV; - if (of_find_property(node, "qcom,saw-reg", &lenp)) { - syscon = of_parse_phandle(node, "qcom,saw-reg", 0); + syscon = of_parse_phandle(node, "qcom,saw-reg", 0); + if (syscon) { saw_regmap = syscon_node_to_regmap(syscon); of_node_put(syscon); if (IS_ERR(saw_regmap))