From: Yang Li Date: Thu, 29 Apr 2021 10:47:10 +0000 (+0800) Subject: ssb: Remove redundant assignment to err X-Git-Tag: v5.14-rc1~119^2~142^2~40 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7557dfde1bd1251793fade20a52014f1105c1012;p=thirdparty%2Flinux.git ssb: Remove redundant assignment to err Variable 'err' is set to zero but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed. Clean up the following clang-analyzer warning: drivers/ssb/main.c:1306:3: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores] drivers/ssb/main.c:1312:3: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores] Reported-by: Abaci Robot Signed-off-by: Yang Li Acked-by: Michael Büsch Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/1619693230-108804-1-git-send-email-yang.lee@linux.alibaba.com --- diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 0e180c36daa41..620cc9dccad79 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -1312,13 +1312,11 @@ static int __init ssb_modinit(void) if (err) { pr_err("Broadcom 43xx PCI-SSB-bridge initialization failed\n"); /* don't fail SSB init because of this */ - err = 0; } err = ssb_host_pcmcia_init(); if (err) { pr_err("PCMCIA host initialization failed\n"); /* don't fail SSB init because of this */ - err = 0; } err = ssb_gige_init(); if (err) {