From: Uwe Kleine-König Date: Wed, 7 Jul 2021 16:28:34 +0000 (+0200) Subject: pwm: sun4i: Don't check the return code of pwmchip_remove() X-Git-Tag: v5.15-rc1~23^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7587f8a863ce4a5514802eeaed48f60663d69179;p=thirdparty%2Fkernel%2Flinux.git pwm: sun4i: Don't check the return code of pwmchip_remove() pwmchip_remove() returns always 0. Don't use the value to make it possible to eventually change the function to return void. Also the driver core ignores the return value of sun4i_pwm_remove() and considers the device removed anyhow. So returning early results in a resource leak. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index c952604e91f3a..91ca67651abd5 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -484,11 +484,8 @@ err_bus: static int sun4i_pwm_remove(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev); - int ret; - ret = pwmchip_remove(&pwm->chip); - if (ret) - return ret; + pwmchip_remove(&pwm->chip); clk_disable_unprepare(pwm->bus_clk); reset_control_assert(pwm->rst);