From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Date: Sun, 19 Oct 2025 08:45:16 +0000 (+0300)
Subject: wifi: iwlwifi: mld: check for NULL pointer after kmalloc
X-Git-Tag: v6.19-rc1~170^2~227^2~1^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=75dd87e3f181bbf7d333c69fa45ef49eb75e4acd;p=thirdparty%2Flinux.git

wifi: iwlwifi: mld: check for NULL pointer after kmalloc

Coverity complained that we didn't add a NULL check for the link we
allocate.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20251019114304.d1f958160c5a.Icc891c14c633c3b8625372680fdc67ca33c83cc7@changeid
---

diff --git a/drivers/net/wireless/intel/iwlwifi/mld/link.c b/drivers/net/wireless/intel/iwlwifi/mld/link.c
index deb1e7227dd85..27ae8bd6f407c 100644
--- a/drivers/net/wireless/intel/iwlwifi/mld/link.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/link.c
@@ -465,10 +465,13 @@ int iwl_mld_add_link(struct iwl_mld *mld,
 	int ret;
 
 	if (!link) {
-		if (is_deflink)
+		if (is_deflink) {
 			link = &mld_vif->deflink;
-		else
+		} else {
 			link = kzalloc(sizeof(*link), GFP_KERNEL);
+			if (!link)
+				return -ENOMEM;
+		}
 	} else {
 		WARN_ON(!mld->fw_status.in_hw_restart);
 	}