From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 6 Jun 2025 05:41:42 +0000 (+0200)
Subject: git-gui: don't delete source files when auto_mkindex fails
X-Git-Tag: v2.50.0-rc2~7^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=765f1db2b5a890c0fa01f8976f197a8483357afe;p=thirdparty%2Fgit.git

git-gui: don't delete source files when auto_mkindex fails

Commit 2cc5b0facfa4 (git-gui: extract script to generate "tclIndex",
2025-03-11) converted commands in a Makefile rule to a shell script.
In this process, the Makefile variable $@ had to be replaced by the
file name that it represents, 'lib/tclIndex'. However, the occurrence
in `rm -f $@` was missed. In a shell script, $@ expands to all
command line arguments, which happen to be the source files lib/*.tcl
in this case. Needless to say that we do not want to remove source
files during a build. Replace $@ by the intended 'lib/tclIndex'.

Reported-by: Randall S. Becker <rsbecker@nexbridge.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---

diff --git a/generate-tclindex.sh b/generate-tclindex.sh
index 36e3a0bd90..0b031d8339 100755
--- a/generate-tclindex.sh
+++ b/generate-tclindex.sh
@@ -23,7 +23,7 @@ then
 	: ok
 else
 	 echo >&2 "    * $TCL_PATH failed; using unoptimized loading"
-	 rm -f $@
+	 rm -f lib/tclIndex
 	 echo '# Autogenerated by git-gui Makefile' >lib/tclIndex
 	 echo >>lib/tclIndex
 	 echo "class.tcl" >>lib/tclIndex