From: Ville Skyttä <ville.skytta@iki.fi>
Date: Fri, 16 Apr 2021 19:19:39 +0000 (+0300)
Subject: completion: avoid aliased command lookup error in nounset mode
X-Git-Tag: v2.32.0-rc0~55^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=76655e8a28d35c7243fa8f138c90a123aa32357f;p=thirdparty%2Fgit.git

completion: avoid aliased command lookup error in nounset mode

Aliased command lookup accesses the `list` variable before it has been
set, causing an error in "nounset" mode. Initialize to an empty string
to avoid that.

    $ git nonexistent-command <Tab>bash: list: unbound variable

Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 1de74f10dd..cd3b13b67b 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1129,7 +1129,7 @@ __git_pretty_aliases ()
 # __git_aliased_command requires 1 argument
 __git_aliased_command ()
 {
-	local cur=$1 last list word cmdline
+	local cur=$1 last list= word cmdline
 
 	while [[ -n "$cur" ]]; do
 		if [[ "$list" == *" $cur "* ]]; then