From: Joseph Myers <joseph@codesourcery.com>
Date: Fri, 4 Nov 2016 16:42:37 +0000 (+0000)
Subject: XFAIL check-execstack for MIPS.
X-Git-Tag: glibc-2.25~344
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7672e712e1cd91a9252bb9db8ac1d9b528e19f2e;p=thirdparty%2Fglibc.git

XFAIL check-execstack for MIPS.

This patch marks the check-execstack test as expected to fail for
MIPS, with a comment referencing previous RFC discussion of the
changes that would be needed to support non-executable stacks on MIPS.

Tested for MIPS (all 24 ABIs).

	* sysdeps/unix/sysv/linux/mips/Makefile [$(subdir) = elf]
	(test-xfail-check-execstack): New variable.
---

diff --git a/ChangeLog b/ChangeLog
index 750243bdab4..babd209bf7d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2016-11-04  Joseph Myers  <joseph@codesourcery.com>
 
+	* sysdeps/unix/sysv/linux/mips/Makefile [$(subdir) = elf]
+	(test-xfail-check-execstack): New variable.
+
 	* sysdeps/mips/localplt.data: New file.
 
 2016-11-04  Yury Norov  <ynorov@caviumnetworks.com>
diff --git a/sysdeps/unix/sysv/linux/mips/Makefile b/sysdeps/unix/sysv/linux/mips/Makefile
index c6729c15f92..bca11d39e03 100644
--- a/sysdeps/unix/sysv/linux/mips/Makefile
+++ b/sysdeps/unix/sysv/linux/mips/Makefile
@@ -99,6 +99,12 @@ sysdep-dl-routines += dl-static
 
 sysdep_routines += dl-vdso
 endif
+
+# Supporting non-executable stacks on MIPS requires changes to both
+# the Linux kernel and glibc.  See
+# <https://sourceware.org/ml/libc-alpha/2016-01/msg00567.html> and
+# <https://sourceware.org/ml/libc-alpha/2016-01/msg00719.html>.
+test-xfail-check-execstack = yes
 endif
 
 ifeq ($(subdir),stdlib)