From: Phil Sutter Date: Tue, 21 Feb 2023 17:36:01 +0000 (+0100) Subject: netlink_delinearize: Sanitize concat data element decoding X-Git-Tag: v1.0.6.1~391 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=767e2ce2dcb3e0950feba8866f14cf02f963a2c4;p=thirdparty%2Fnftables.git netlink_delinearize: Sanitize concat data element decoding commit 1344d9e53ba4d67cedd13a2c76a970fc7ce65683 upstream. The call to netlink_get_register() might return NULL, catch this before dereferencing the pointer. Fixes: db59a5c1204c9 ("netlink_delinearize: fix decoding of concat data element") Signed-off-by: Phil Sutter Acked-by: Florian Westphal --- diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c index fe3246b2..b413f60e 100644 --- a/src/netlink_delinearize.c +++ b/src/netlink_delinearize.c @@ -1661,7 +1661,7 @@ static void netlink_parse_dynset(struct netlink_parse_ctx *ctx, sreg_data = netlink_parse_register(nle, NFTNL_EXPR_DYNSET_SREG_DATA); expr_data = netlink_get_register(ctx, loc, sreg_data); - if (expr_data->len < set->data->len) { + if (expr_data && expr_data->len < set->data->len) { expr_free(expr_data); expr_data = netlink_parse_concat_expr(ctx, loc, sreg_data, set->data->len); if (expr_data == NULL)