From: Christian Brauner Date: Mon, 25 Nov 2024 14:10:23 +0000 (+0100) Subject: cachefiles: avoid pointless cred reference count bump X-Git-Tag: v6.14-rc1~214^2~1^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=76a40086683933431660b348dbfefa80b9eaaa03;p=thirdparty%2Fkernel%2Flinux.git cachefiles: avoid pointless cred reference count bump The cache holds a long-term reference to the credentials that's taken when the cache is created and put when the cache becomes unused. Link: https://lore.kernel.org/r/20241125-work-cred-v2-27-68b9d38bb5b2@kernel.org Reviewed-by: Jeff Layton Reviewed-by: Jens Axboe Signed-off-by: Christian Brauner --- diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h index 1cfeb3b383190..7b99bd98de75b 100644 --- a/fs/cachefiles/internal.h +++ b/fs/cachefiles/internal.h @@ -393,13 +393,13 @@ extern int cachefiles_determine_cache_security(struct cachefiles_cache *cache, static inline void cachefiles_begin_secure(struct cachefiles_cache *cache, const struct cred **_saved_cred) { - *_saved_cred = override_creds(get_new_cred(cache->cache_cred)); + *_saved_cred = override_creds(cache->cache_cred); } static inline void cachefiles_end_secure(struct cachefiles_cache *cache, const struct cred *saved_cred) { - put_cred(revert_creds(saved_cred)); + revert_creds(saved_cred); } /*