From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Thu, 3 Apr 2025 13:17:53 +0000 (+0200)
Subject: MINOR: backend: mark srv as nonnull in alloc_dst_address()
X-Git-Tag: v3.2-dev10~33
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=76e9156c9b4ebebdd2f20a4d9aa862f2f6d66e3b;p=thirdparty%2Fhaproxy.git

MINOR: backend: mark srv as nonnull in alloc_dst_address()

Server instance can be NULL on connect_server(), either when dispatch or
transparent proxy are active. However, in alloc_dst_address() access to
<srv> is safe thanks to SF_ASSIGNED stream flag. Add an ASSUME_NONNULL()
to reflect this state.

This should fix coverity report from github issue #2922.
---

diff --git a/src/backend.c b/src/backend.c
index 8a3399efa..e49a12d05 100644
--- a/src/backend.c
+++ b/src/backend.c
@@ -888,6 +888,8 @@ static int alloc_dst_address(struct sockaddr_storage **ss,
 		if (!sockaddr_alloc(ss, NULL, 0))
 			return SRV_STATUS_INTERNAL;
 
+		ASSUME_NONNULL(srv); /* srv is guaranteed by SF_ASSIGNED */
+
 		**ss = srv->addr;
 		set_host_port(*ss, srv->svc_port);
 		if (!is_addr(*ss)) {