From: Xiongfeng Wang Date: Wed, 16 Mar 2022 12:34:52 +0000 (+0100) Subject: media: mtk-vcodec: Add missing of_node_put() in mtk_vdec_hw_prob_done() X-Git-Tag: v5.18-rc1~153^2~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=77119adb62dda4918cb21755775d3cacd3e83097;p=thirdparty%2Fkernel%2Flinux.git media: mtk-vcodec: Add missing of_node_put() in mtk_vdec_hw_prob_done() of_find_compatible_node() will increment the refcount of the returned device_node. Calling of_node_put() to avoid the refcount leak. Link: https://lore.kernel.org/linux-media/20220316123452.186166-1-wangxiongfeng2@huawei.com Signed-off-by: Xiongfeng Wang Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c index 8d2a641d92f10..60da59611434c 100644 --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c @@ -47,6 +47,8 @@ static int mtk_vdec_hw_prob_done(struct mtk_vcodec_dev *vdec_dev) if (!subdev_node) continue; + of_node_put(subdev_node); + hw_idx = (enum mtk_vdec_hw_id)(uintptr_t)of_id->data; if (!test_bit(hw_idx, vdec_dev->subdev_bitmap)) { dev_err(&pdev->dev, "vdec %d is not ready", hw_idx);