From: Mike Looijmans Date: Tue, 24 Apr 2018 11:10:30 +0000 (+0200) Subject: gpio-poweroff: Use gpiod_set_value_cansleep X-Git-Tag: v4.18-rc1~77^2~14 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=77142a611252de84ac533842438d19e7b2f494e7;p=thirdparty%2Fkernel%2Flinux.git gpio-poweroff: Use gpiod_set_value_cansleep The power-off call is done in a context that must be able to sleep, so use gpiod_set_value_cansleep instead of the atomic gpiod_set_value call. This fixes a kernel warning at shutdown when the gpio is controlled through an IO expander for example. Signed-off-by: Mike Looijmans Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/reset/gpio-poweroff.c b/drivers/power/reset/gpio-poweroff.c index 6273ad3b411d8..38206c39b3bff 100644 --- a/drivers/power/reset/gpio-poweroff.c +++ b/drivers/power/reset/gpio-poweroff.c @@ -35,11 +35,11 @@ static void gpio_poweroff_do_poweroff(void) gpiod_direction_output(reset_gpio, 1); mdelay(100); /* drive inactive, also active->inactive edge */ - gpiod_set_value(reset_gpio, 0); + gpiod_set_value_cansleep(reset_gpio, 0); mdelay(100); /* drive it active, also inactive->active edge */ - gpiod_set_value(reset_gpio, 1); + gpiod_set_value_cansleep(reset_gpio, 1); /* give it some time */ mdelay(timeout);