From: Simon Marchi <simon.marchi@efficios.com>
Date: Fri, 23 May 2025 18:35:29 +0000 (-0400)
Subject: gdb: use local addrmap_mutable in addrmap selftest
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=77307a766b6bb1ddd3604f335f30f2e751e77f45;p=thirdparty%2Fbinutils-gdb.git

gdb: use local addrmap_mutable in addrmap selftest

There is no need to allocate the addrmap_mutable on the heap.

Change-Id: Ia6ec17101a44ae5eaffbf3382c9639414ce5343e
Approved-By: Andrew Burgess <aburgess@redhat.com>
---

diff --git a/gdb/addrmap.c b/gdb/addrmap.c
index 929713573be..ea8bf0ec6cb 100644
--- a/gdb/addrmap.c
+++ b/gdb/addrmap.c
@@ -427,21 +427,20 @@ test_addrmap ()
 
   /* Create mutable addrmap.  */
   auto_obstack temp_obstack;
-  auto map = std::make_unique<struct addrmap_mutable> ();
-  SELF_CHECK (map != nullptr);
+  addrmap_mutable map;
 
   /* Check initial state.  */
-  check_addrmap_find (*map, array, 0, 19, nullptr);
+  check_addrmap_find (map, array, 0, 19, nullptr);
 
   /* Insert address range into mutable addrmap.  */
-  map->set_empty (core_addr (&array[10]), core_addr (&array[12]), val1);
-  check_addrmap_find (*map, array, 0, 9, nullptr);
-  check_addrmap_find (*map, array, 10, 12, val1);
-  check_addrmap_find (*map, array, 13, 19, nullptr);
+  map.set_empty (core_addr (&array[10]), core_addr (&array[12]), val1);
+  check_addrmap_find (map, array, 0, 9, nullptr);
+  check_addrmap_find (map, array, 10, 12, val1);
+  check_addrmap_find (map, array, 13, 19, nullptr);
 
   /* Create corresponding fixed addrmap.  */
   addrmap_fixed *map2
-    = new (&temp_obstack) addrmap_fixed (&temp_obstack, map.get ());
+    = new (&temp_obstack) addrmap_fixed (&temp_obstack, &map);
   SELF_CHECK (map2 != nullptr);
   check_addrmap_find (*map2, array, 0, 9, nullptr);
   check_addrmap_find (*map2, array, 10, 12, val1);
@@ -460,7 +459,7 @@ test_addrmap ()
 	SELF_CHECK (false);
       return 0;
     };
-  SELF_CHECK (map->foreach (callback) == 0);
+  SELF_CHECK (map.foreach (callback) == 0);
   SELF_CHECK (map2->foreach (callback) == 0);
 
   /* Relocate fixed addrmap.  */
@@ -470,11 +469,11 @@ test_addrmap ()
   check_addrmap_find (*map2, array, 14, 19, nullptr);
 
   /* Insert partially overlapping address range into mutable addrmap.  */
-  map->set_empty (core_addr (&array[11]), core_addr (&array[13]), val2);
-  check_addrmap_find (*map, array, 0, 9, nullptr);
-  check_addrmap_find (*map, array, 10, 12, val1);
-  check_addrmap_find (*map, array, 13, 13, val2);
-  check_addrmap_find (*map, array, 14, 19, nullptr);
+  map.set_empty (core_addr (&array[11]), core_addr (&array[13]), val2);
+  check_addrmap_find (map, array, 0, 9, nullptr);
+  check_addrmap_find (map, array, 10, 12, val1);
+  check_addrmap_find (map, array, 13, 13, val2);
+  check_addrmap_find (map, array, 14, 19, nullptr);
 }
 
 } /* namespace selftests */