From: Christoph Hellwig Date: Thu, 16 Jan 2025 21:22:03 +0000 (-0800) Subject: xfs: don't return an error from xfs_update_last_rtgroup_size for !XFS_RT X-Git-Tag: v6.13.0~16 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=773c4c6f33cfd0a909fb742f149bd6f59cfa62b6;p=thirdparty%2Fxfsprogs-dev.git xfs: don't return an error from xfs_update_last_rtgroup_size for !XFS_RT Source kernel commit: 7ee7c9b39ed36caf983706f5b893cc5c37a79071 Non-rtg file systems have a fake RT group even if they do not have a RT device, and thus an rgcount of 1. Ensure xfs_update_last_rtgroup_size doesn't fail when called for !XFS_RT to handle this case. Fixes: 87fe4c34a383 ("xfs: create incore realtime group structures") Reported-by: Brian Foster Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong Signed-off-by: Carlos Maiolino --- diff --git a/libxfs/xfs_rtgroup.h b/libxfs/xfs_rtgroup.h index 7e7e491f..2d782264 100644 --- a/libxfs/xfs_rtgroup.h +++ b/libxfs/xfs_rtgroup.h @@ -272,7 +272,7 @@ static inline int xfs_initialize_rtgroups(struct xfs_mount *mp, } # define xfs_rtgroup_extents(mp, rgno) (0) -# define xfs_update_last_rtgroup_size(mp, rgno) (-EOPNOTSUPP) +# define xfs_update_last_rtgroup_size(mp, rgno) (0) # define xfs_rtgroup_lock(rtg, gf) ((void)0) # define xfs_rtgroup_unlock(rtg, gf) ((void)0) # define xfs_rtgroup_trans_join(tp, rtg, gf) ((void)0)