From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Fri, 15 Nov 2024 02:28:40 +0000 (-0500)
Subject: bcachefs: Delete backpointers check in try_alloc_bucket()
X-Git-Tag: v6.14-rc1~204^2~177
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7815809fca37b0e6287de349f88b2d5d6eadd82d;p=thirdparty%2Fkernel%2Flinux.git

bcachefs: Delete backpointers check in try_alloc_bucket()

try_alloc_bucket() has a "safety" check, which avoids allocating a
bucket if there's any backpointers present.

But backpointers are not the source of truth for live data in a bucket,
the bucket sector counts are; this check was fairly useless, and we're
also deferring backpointers checks from fsck to runtime in the near
future.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c
index 955ea6ae868fc..6d665b720f725 100644
--- a/fs/bcachefs/alloc_foreground.c
+++ b/fs/bcachefs/alloc_foreground.c
@@ -290,26 +290,6 @@ static struct open_bucket *try_alloc_bucket(struct btree_trans *trans, struct bc
 	if (ret)
 		return NULL;
 
-	if (unlikely(c->curr_recovery_pass <= BCH_RECOVERY_PASS_check_extents_to_backpointers)) {
-		struct bch_backpointer bp;
-		struct bpos bp_pos = POS_MIN;
-
-		ret = bch2_get_next_backpointer(trans, ca, POS(ca->dev_idx, b), -1,
-						&bp_pos, &bp,
-						BTREE_ITER_nopreserve);
-		if (ret)
-			return ERR_PTR(ret);
-
-		if (!bkey_eq(bp_pos, POS_MAX)) {
-			/*
-			 * Bucket may have data in it - we don't call
-			 * bch2_trans_inconsistent() because fsck hasn't
-			 * finished yet
-			 */
-			return NULL;
-		}
-	}
-
 	return __try_alloc_bucket(c, ca, b, gen, watermark, s, cl);
 }