From: René Scharfe Date: Sat, 18 Nov 2017 10:20:04 +0000 (+0100) Subject: config: flip return value of write_section() X-Git-Tag: v2.15.1~1^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=782c030ea21f02a5dfab3fd023e14084ebeff4dc;p=thirdparty%2Fgit.git config: flip return value of write_section() d9bd4cbb9cc (config: flip return value of store_write_*()) made write_section() follow the convention of write(2) to return -1 on error and the number of written bytes on success. 3b48045c6c7 (Merge branch 'sd/branch-copy') changed it back to returning 0 on error and 1 on success, but left its callers still checking for negative values. Let write_section() follow the convention of write(2) again to meet the expectations of its callers. Reported-by: Jeff King Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano --- diff --git a/config.c b/config.c index 4831c12735..201ad36d34 100644 --- a/config.c +++ b/config.c @@ -2319,7 +2319,7 @@ static ssize_t write_section(int fd, const char *key) struct strbuf sb = store_create_section(key); ssize_t ret; - ret = write_in_full(fd, sb.buf, sb.len) == sb.len; + ret = write_in_full(fd, sb.buf, sb.len); strbuf_release(&sb); return ret;