From: Junio C Hamano Date: Sun, 29 Mar 2020 03:06:53 +0000 (-0700) Subject: CodingGuidelines: allow ${#posix} == strlen($posix) X-Git-Tag: v2.27.0-rc0~122^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=78725ebda9577ec86a9657d20b8ee8c2a099601d;p=thirdparty%2Fgit.git CodingGuidelines: allow ${#posix} == strlen($posix) The construct has been in POSIX for the past 10+ years, and we have used in t9xxx (subversion) series of the tests, so we know it is at portable across systems that people have run those tests, which is almost everything we'd care about. Let's loosen the rule; luckily, the check-non-portable-shell script does not have any rule to find its use, so the only change needed is a removal of one paragraph from the documentation. Helped-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index f45db5b727..af50c707a9 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -91,8 +91,6 @@ For shell scripts specifically (not exhaustive): - No shell arrays. - - No strlen ${#parameter}. - - No pattern replacement ${parameter/pattern/string}. - We use Arithmetic Expansion $(( ... )).