From: Alejandro Colomar <alx@kernel.org>
Date: Sat, 27 May 2023 13:56:08 +0000 (+0200)
Subject: Use temporary variable
X-Git-Tag: 4.14.0-rc1~47
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=787ea57a186e0e7a60c75026038056cc2131ec0c;p=thirdparty%2Fshadow.git

Use temporary variable

-  Use the temporary variable more, as it helps readability: it removes
   a derefecence, which itself allows removing some parentheses.

-  Use a shorter name, which is more common with temporaries, and so
   there's less to read.

-  Assign to *ranges at the end of the function.  It's the same, but
   with the other changes, I think this makes it slightly clearer.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/subordinateio.c b/lib/subordinateio.c
index 52d0e33d1..4139674f0 100644
--- a/lib/subordinateio.c
+++ b/lib/subordinateio.c
@@ -315,15 +315,16 @@ static bool have_range(struct commonio_db *db,
 
 static bool append_range(struct subid_range **ranges, const struct subordinate_range *new, int n)
 {
-	struct subid_range  *alloced;
+	struct subid_range  *sr;
 
-	alloced = REALLOC(*ranges, n + 1, struct subid_range);
-	if (!alloced)
+	sr = REALLOC(*ranges, n + 1, struct subid_range);
+	if (!sr)
 		return false;
-	*ranges = alloced;
 
-	(*ranges)[n].start = new->start;
-	(*ranges)[n].count = new->count;
+	sr[n].start = new->start;
+	sr[n].count = new->count;
+	*ranges = sr;
+
 	return true;
 }