From: Jacopo Mondi Date: Sun, 10 Aug 2025 01:29:59 +0000 (+0300) Subject: media: rcar-vin: Do not set file->private_data X-Git-Tag: v6.18-rc1~133^2~421 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=78b2c8a6cd2fed89ad98213558531a7db52a0eea;p=thirdparty%2Fkernel%2Flinux.git media: rcar-vin: Do not set file->private_data The R-Car VIN driver sets file->private_data to the driver-specific structure, but the following call to v4l2_fh_open() overwrites it with a pointer to the just allocated v4l2_fh. Remove the mis-leading assignment in the driver. Signed-off-by: Jacopo Mondi Reviewed-by: Niklas Söderlund Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c index 62eddf3a35fc9..079dbaf016c25 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c @@ -588,8 +588,6 @@ static int rvin_open(struct file *file) if (ret) goto err_pm; - file->private_data = vin; - ret = v4l2_fh_open(file); if (ret) goto err_unlock;