From: Pedro Alves Date: Thu, 9 May 2024 12:01:53 +0000 (+0100) Subject: gdb sim testing, set gdb_protocol to "sim" X-Git-Tag: gdb-15-branchpoint~140 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=78b2db9e7f5a04fdc030a5c65f8873a2c3d3c187;p=thirdparty%2Fbinutils-gdb.git gdb sim testing, set gdb_protocol to "sim" Bernd reported that when testing with riscv-unknown-elf target using the simulator, before commit c7a2ee649115 ("gdb_is_target_native -> gdb_protocol_is_native"), he had: PASS: gdb.base/load-command.exp: probe for target native PASS: gdb.base/load-command.exp: check initial value of the_variable PASS: gdb.base/load-command.exp: manually change the_variable PASS: gdb.base/load-command.exp: check manually changed value of the_variable PASS: gdb.base/load-command.exp: reload: re-load binary PASS: gdb.base/load-command.exp: reload: check initial value of the_variable and now: UNSUPPORTED: gdb.base/load-command.exp: the native target does not support the load command The problem is that the sim board/config isn't setting gdb_protocol anywhere, so gdb_protocol_is_native returns true. This commit fixes it by making gdb/testsuite/config/sim.exp set gdb_protocol to "sim". Reported-by: Bernd Edlinger Tested-by: Bernd Edlinger Change-Id: I48a7afed004a3517b90220674fe5bc856fe7d09a --- diff --git a/gdb/testsuite/config/sim.exp b/gdb/testsuite/config/sim.exp index 81736d25814..da2780e1d47 100644 --- a/gdb/testsuite/config/sim.exp +++ b/gdb/testsuite/config/sim.exp @@ -14,6 +14,10 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . +# If we left this empty, the core of the testsuite would think we were +# connecting to the native target. +set_board_info gdb_protocol "sim" + # # gdb_target_sim # Set gdb to target the simulator