From: Jiang Biao Date: Wed, 24 Apr 2019 00:58:57 +0000 (+0800) Subject: fs/quota: erase unused but set variable warning X-Git-Tag: v5.2-rc1~82^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=78bc3334a69ff289dbc973a9db7c52a2d7757e5b;p=thirdparty%2Fkernel%2Flinux.git fs/quota: erase unused but set variable warning Local variable *reserved* of remove_dquot_ref() is only used if define CONFIG_QUOTA_DEBUG, but not ebraced in CONFIG_QUOTA_DEBUG macro, which leads to unused-but-set-variable warning when compiling. This patch ebrace it into CONFIG_QUOTA_DEBUG macro like what is done in add_dquot_ref(). Signed-off-by: Jiang Biao Signed-off-by: Jan Kara --- diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index d2f2972b33db8..67e534dbfc0e8 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -1050,7 +1050,9 @@ static void remove_dquot_ref(struct super_block *sb, int type, struct list_head *tofree_head) { struct inode *inode; +#ifdef CONFIG_QUOTA_DEBUG int reserved = 0; +#endif spin_lock(&sb->s_inode_list_lock); list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { @@ -1062,8 +1064,10 @@ static void remove_dquot_ref(struct super_block *sb, int type, */ spin_lock(&dq_data_lock); if (!IS_NOQUOTA(inode)) { +#ifdef CONFIG_QUOTA_DEBUG if (unlikely(inode_get_rsv_space(inode) > 0)) reserved = 1; +#endif remove_inode_dquot_ref(inode, type, tofree_head); } spin_unlock(&dq_data_lock);