From: Heiko Stuebner Date: Mon, 18 Aug 2025 18:56:58 +0000 (+0200) Subject: accel/rocket: Check the correct DMA irq status to warn about X-Git-Tag: v6.18-rc1~134^2~16^2~32 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=78e399955d352a2387a4b22713385a0c5d737685;p=thirdparty%2Fkernel%2Flinux.git accel/rocket: Check the correct DMA irq status to warn about Right now, the code checks the DMA_READ_ERROR state 2 times, while I guess it was supposed to warn about both read and write errors. Change the 2nd check to look at the write-error flag. Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL") Signed-off-by: Heiko Stuebner Signed-off-by: Tomeu Vizoso Link: https://lore.kernel.org/r/20250818185658.2585696-1-heiko@sntech.de --- diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index f6fe1a6d9264b..acd606160dc9b 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -422,7 +422,7 @@ static irqreturn_t rocket_job_irq_handler(int irq, void *data) u32 raw_status = rocket_pc_readl(core, INTERRUPT_RAW_STATUS); WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR); - WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR); + WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_WRITE_ERROR); if (!(raw_status & PC_INTERRUPT_RAW_STATUS_DPU_0 || raw_status & PC_INTERRUPT_RAW_STATUS_DPU_1))