From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 4 Jun 2015 17:50:32 +0000 (-0400)
Subject: Fix brin "char" test to actually test what it meant to test.
X-Git-Tag: REL9_5_ALPHA1~116
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=78e72794a76fef3233c06800c6046aaad0704a22;p=thirdparty%2Fpostgresql.git

Fix brin "char" test to actually test what it meant to test.

Casting to char, without quotes, does not give the same results as casting
to "char".  That meant we were not testing the brin "char" paths at all,
since we ended up with a text operator not a "char" operator.
---

diff --git a/src/test/regress/expected/brin.out b/src/test/regress/expected/brin.out
index ba0824428ec..b45c77a0649 100644
--- a/src/test/regress/expected/brin.out
+++ b/src/test/regress/expected/brin.out
@@ -96,7 +96,7 @@ CREATE TABLE brinopers (colname name, typ text, op text[], value text[],
 	check (cardinality(op) = cardinality(value)));
 INSERT INTO brinopers VALUES
 	('byteacol', 'bytea', '{>, >=, =, <=, <}', '{AAAAAA, AAAAAA, BNAAAABNAAAABNAAAABNAAAABNAAAABNAAAABNAAAABNAAAA, ZZZZZZ, ZZZZZZ}'),
-	('charcol', 'char', '{>, >=, =, <=, <}', '{A, A, M, Z, Z}'),
+	('charcol', '"char"', '{>, >=, =, <=, <}', '{A, A, M, Z, Z}'),
 	('namecol', 'name', '{>, >=, =, <=, <}', '{AAAAAA, AAAAAA, MAAAAA, ZZAAAA, ZZAAAA}'),
 	('int2col', 'int2', '{>, >=, =, <=, <}', '{0, 0, 800, 999, 999}'),
 	('int2col', 'int4', '{>, >=, =, <=, <}', '{0, 0, 800, 999, 1999}'),
diff --git a/src/test/regress/sql/brin.sql b/src/test/regress/sql/brin.sql
index 881a13b1b0b..9a8baef812a 100644
--- a/src/test/regress/sql/brin.sql
+++ b/src/test/regress/sql/brin.sql
@@ -101,7 +101,7 @@ CREATE TABLE brinopers (colname name, typ text, op text[], value text[],
 
 INSERT INTO brinopers VALUES
 	('byteacol', 'bytea', '{>, >=, =, <=, <}', '{AAAAAA, AAAAAA, BNAAAABNAAAABNAAAABNAAAABNAAAABNAAAABNAAAABNAAAA, ZZZZZZ, ZZZZZZ}'),
-	('charcol', 'char', '{>, >=, =, <=, <}', '{A, A, M, Z, Z}'),
+	('charcol', '"char"', '{>, >=, =, <=, <}', '{A, A, M, Z, Z}'),
 	('namecol', 'name', '{>, >=, =, <=, <}', '{AAAAAA, AAAAAA, MAAAAA, ZZAAAA, ZZAAAA}'),
 	('int2col', 'int2', '{>, >=, =, <=, <}', '{0, 0, 800, 999, 999}'),
 	('int2col', 'int4', '{>, >=, =, <=, <}', '{0, 0, 800, 999, 1999}'),