From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 19 Jul 2022 20:32:12 +0000 (+0200)
Subject: mprintf: fix *dyn_vprintf() when out-of-memory
X-Git-Tag: curl-7_85_0~149
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7935972b37a30ac5937c3e253dbb7b7ae7f38ee3;p=thirdparty%2Fcurl.git

mprintf: fix *dyn_vprintf() when out-of-memory

Follow-up to 0e48ac1f99a. Torture-testing 1455 would lead to a memory
leak otherwise.

Closes #9185
---

diff --git a/lib/mprintf.c b/lib/mprintf.c
index 1d8052dcd6..30347de250 100644
--- a/lib/mprintf.c
+++ b/lib/mprintf.c
@@ -1068,13 +1068,12 @@ extern int Curl_dyn_vprintf(struct dynbuf *dyn,
 /* appends the formatted string, returns 0 on success, 1 on error */
 int Curl_dyn_vprintf(struct dynbuf *dyn, const char *format, va_list ap_save)
 {
-  int retcode;
   struct asprintf info;
   info.b = dyn;
   info.fail = 0;
 
-  retcode = dprintf_formatf(&info, alloc_addbyter, format, ap_save);
-  if(!retcode && info.fail) {
+  (void)dprintf_formatf(&info, alloc_addbyter, format, ap_save);
+  if(info.fail) {
     Curl_dyn_free(info.b);
     return 1;
   }