From: René Scharfe <l.s.r@web.de>
Date: Sat, 1 Oct 2022 10:25:36 +0000 (+0200)
Subject: revision: use strtol_i() for exclude_parent
X-Git-Tag: v2.39.0-rc0~87^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=793c21182e34f109b4f438944b4272fb50862ad5;p=thirdparty%2Fgit.git

revision: use strtol_i() for exclude_parent

Avoid silent overflow of the int exclude_parent by using the appropriate
function, strtol_i(), to parse its value.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/revision.c b/revision.c
index 0c6e26cd9c..da9dfd405e 100644
--- a/revision.c
+++ b/revision.c
@@ -2112,9 +2112,8 @@ static int handle_revision_arg_1(const char *arg_, struct rev_info *revs, int fl
 		int exclude_parent = 1;
 
 		if (mark[2]) {
-			char *end;
-			exclude_parent = strtoul(mark + 2, &end, 10);
-			if (*end != '\0' || !exclude_parent)
+			if (strtol_i(mark + 2, 10, &exclude_parent) ||
+			    exclude_parent < 1)
 				return -1;
 		}