From: Philippe Mathieu-Daudé Date: Wed, 21 Dec 2022 18:51:25 +0000 (+0100) Subject: hw/arm/bcm2836: Use ARM_CPU 'mp-affinity' property X-Git-Tag: v9.0.0-rc0~123^2~32 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=79f5169501396ba90a32971fc66886fcf60ec52f;p=thirdparty%2Fqemu.git hw/arm/bcm2836: Use ARM_CPU 'mp-affinity' property The 'mp-affinity' property is present since commit 15a21fe028 ("target-arm: Add mp-affinity property for ARM CPU class"). Use it and remove a /* TODO */ comment. Since all ARM CPUs have this property, use &error_abort, because this call can not fail. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20231123143813.42632-4-philmd@linaro.org> --- diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index a1bd1406e14..289c30e6b6f 100644 --- a/hw/arm/bcm2836.c +++ b/hw/arm/bcm2836.c @@ -127,8 +127,8 @@ static void bcm2836_realize(DeviceState *dev, Error **errp) qdev_get_gpio_in_named(DEVICE(&s->control), "gpu-fiq", 0)); for (n = 0; n < BCM283X_NCPUS; n++) { - /* TODO: this should be converted to a property of ARM_CPU */ - s->cpu[n].core.mp_affinity = (bc->clusterid << 8) | n; + object_property_set_int(OBJECT(&s->cpu[n].core), "mp-affinity", + (bc->clusterid << 8) | n, &error_abort); /* set periphbase/CBAR value for CPU-local registers */ object_property_set_int(OBJECT(&s->cpu[n].core), "reset-cbar",