From: Jakub Kicinski Date: Sat, 7 Dec 2024 01:47:34 +0000 (-0800) Subject: Merge branch 'net-phylib-eee-cleanups' X-Git-Tag: v6.14-rc1~162^2~270 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7a2716ac9a5b2a2dd0443b101766d3721f094ee1;p=thirdparty%2Fkernel%2Flinux.git Merge branch 'net-phylib-eee-cleanups' Russell King says: ==================== net: phylib EEE cleanups Clean up phylib's EEE support. Patches previously posted as RFC as part of the phylink EEE series. Patch 1 changes the Marvell driver to use the state we store in struct phy_device, rather than manually calling phydev->eee_cfg.eee_enabled. Patch 2 avoids genphy_c45_ethtool_get_eee() setting ->eee_enabled, as we copy that from phydev->eee_cfg.eee_enabled later, and after patch 3 mo one uses this after calling genphy_c45_ethtool_get_eee(). In fact, the only caller of this function now is phy_ethtool_get_eee(). As all callers to genphy_c45_eee_is_active() now pass NULL as its is_enabled flag, this is no longer useful. Remove the argument in patch 3. Patch 4 updates the phylib documentation to make it absolutely clear that phy_ethtool_get_eee() now fills in all members of struct ethtool_keee, which is why we now have so many buggy network drivers. ==================== Link: https://patch.msgid.link/Z1GDZlFyF2fsFa3S@shell.armlinux.org.uk Signed-off-by: Jakub Kicinski --- 7a2716ac9a5b2a2dd0443b101766d3721f094ee1