From: Karel Zak Date: Wed, 17 May 2017 10:45:30 +0000 (+0200) Subject: libmount: don't pass -1 to close() [coverity scan] X-Git-Tag: v2.30-rc2~18 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7a5dbd22588fcf402ab15f82917891d176dfca74;p=thirdparty%2Futil-linux.git libmount: don't pass -1 to close() [coverity scan] Signed-off-by: Karel Zak --- diff --git a/libmount/src/utils.c b/libmount/src/utils.c index 3b27135cdb..a5617e6c02 100644 --- a/libmount/src/utils.c +++ b/libmount/src/utils.c @@ -647,7 +647,7 @@ done: static int try_write(const char *filename) { - int fd, ret = 0; + int fd, rc = 0; if (!filename) return -EINVAL; @@ -655,9 +655,10 @@ static int try_write(const char *filename) fd = open(filename, O_RDWR|O_CREAT|O_CLOEXEC, S_IWUSR|S_IRUSR|S_IRGRP|S_IROTH); if (fd < 0) - ret = -errno; - close(fd); - return ret; + rc = -errno; + else + close(fd); + return rc; } /**