From: Selva Nair Date: Wed, 8 Aug 2018 02:44:31 +0000 (-0400) Subject: Accept empty password and/or response in auth-pam plugin X-Git-Tag: v2.5_beta1~449 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7a8109023f4c345fe12f23421c5fa7e88e1ea85b;p=thirdparty%2Fopenvpn.git Accept empty password and/or response in auth-pam plugin In the auth-pam plugin correctly parse the static challenge string even when password or challenge response is empty. Whether an empty user input is an error is determined by the PAM conversation function depending on whether the PAM module queries for it or not. Signed-off-by: Selva Nair Acked-by: Gert Doering Message-Id: <1533696271-21799-2-git-send-email-selva.nair@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17382.html Signed-off-by: Gert Doering --- diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c index 1324307f1..88b53204b 100644 --- a/src/plugins/auth-pam/auth-pam.c +++ b/src/plugins/auth-pam/auth-pam.c @@ -310,11 +310,11 @@ split_scrv1_password(struct user_pass *up) *resp++ = '\0'; int n = plugin_base64_decode(pass, up->password, sizeof(up->password)-1); - if (n > 0) + if (n >= 0) { up->password[n] = '\0'; n = plugin_base64_decode(resp, up->response, sizeof(up->response)-1); - if (n > 0) + if (n >= 0) { up->response[n] = '\0'; if (DEBUG(up->verb))