From: Amit Vadhavana Date: Sat, 16 Nov 2024 15:21:36 +0000 (+0530) Subject: selftests: refactor the lsm `flags_overset_lsm_set_self_attr` test X-Git-Tag: v6.14-rc1~166^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7a9b65ab0abd52ae646ba327522315d7500a7d4f;p=thirdparty%2Fkernel%2Flinux.git selftests: refactor the lsm `flags_overset_lsm_set_self_attr` test Remove the temporary context variable `tctx` to simplify the code. use the original context `ctx` directly in calls to `lsm_get_self_attr`, eliminating redundancy without any functional changes. Reviewed-by: Casey Schaufler Reviewed-by: Shuah Khan Signed-off-by: Amit Vadhavana [PM: subject tweak] Signed-off-by: Paul Moore --- diff --git a/tools/testing/selftests/lsm/lsm_set_self_attr_test.c b/tools/testing/selftests/lsm/lsm_set_self_attr_test.c index 66dec47e3ca3f..732e89fe99c08 100644 --- a/tools/testing/selftests/lsm/lsm_set_self_attr_test.c +++ b/tools/testing/selftests/lsm/lsm_set_self_attr_test.c @@ -56,16 +56,15 @@ TEST(flags_zero_lsm_set_self_attr) TEST(flags_overset_lsm_set_self_attr) { const long page_size = sysconf(_SC_PAGESIZE); - char *ctx = calloc(page_size, 1); + struct lsm_ctx *ctx = calloc(page_size, 1); __u32 size = page_size; - struct lsm_ctx *tctx = (struct lsm_ctx *)ctx; ASSERT_NE(NULL, ctx); if (attr_lsm_count()) { - ASSERT_LE(1, lsm_get_self_attr(LSM_ATTR_CURRENT, tctx, &size, + ASSERT_LE(1, lsm_get_self_attr(LSM_ATTR_CURRENT, ctx, &size, 0)); } - ASSERT_EQ(-1, lsm_set_self_attr(LSM_ATTR_CURRENT | LSM_ATTR_PREV, tctx, + ASSERT_EQ(-1, lsm_set_self_attr(LSM_ATTR_CURRENT | LSM_ATTR_PREV, ctx, size, 0)); free(ctx);