From: William Lallemand <wlallemand@haproxy.com>
Date: Fri, 2 May 2025 14:12:41 +0000 (+0200)
Subject: MINOR: acme: emit a log when the scheduler can't start the task
X-Git-Tag: v3.2-dev14~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7ad501e6a1da1c34f96295076ea608a6b67e26e2;p=thirdparty%2Fhaproxy.git

MINOR: acme: emit a log when the scheduler can't start the task

Emit an error log when the renewal scheduler can't start the task.
---

diff --git a/src/acme.c b/src/acme.c
index e59d4017e..c2e37c130 100644
--- a/src/acme.c
+++ b/src/acme.c
@@ -2050,6 +2050,7 @@ struct task *acme_scheduler(struct task *task, void *context, unsigned int state
 {
 	struct ebmb_node *node = NULL;
 	struct ckch_store *store = NULL;
+	char *errmsg = NULL;
 
 	if (HA_SPIN_TRYLOCK(CKCH_LOCK, &ckch_lock))
 		return task;
@@ -2061,7 +2062,10 @@ struct task *acme_scheduler(struct task *task, void *context, unsigned int state
 		if (store->conf.acme.id) {
 
 			if (acme_will_expire(store)) {
-				acme_start_task(store, NULL);
+				if (acme_start_task(store, &errmsg) != 0) {
+					send_log(NULL, LOG_NOTICE,"acme: %s: %s, aborting.\n", store->path, errmsg ? errmsg : "");
+					ha_free(&errmsg);
+				}
 			}
 		}
 		node = ebmb_next(node);