From: Simon Marchi <simon.marchi@efficios.com>
Date: Thu, 5 Jun 2025 20:30:24 +0000 (-0400)
Subject: gdb/solib-rocm: remove one xfree
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7ad52074d2cb2478372fe16cf9bf1037f7ff67d4;p=thirdparty%2Fbinutils-gdb.git

gdb/solib-rocm: remove one xfree

Replace a manual xfree with unique_xmalloc_ptr.

Change-Id: I12a20106545905f1a80d069fc0555812cc3d6680
Approved-By: Tom Tromey <tom@tromey.com>
Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)
---

diff --git a/gdb/solib-rocm.c b/gdb/solib-rocm.c
index 92fb91563f0..b27613bbf91 100644
--- a/gdb/solib-rocm.c
+++ b/gdb/solib-rocm.c
@@ -703,6 +703,9 @@ rocm_update_solib_list ()
       return;
     }
 
+  gdb::unique_xmalloc_ptr<amd_dbgapi_code_object_id_t> code_object_list_holder
+    (code_object_list);
+
   for (size_t i = 0; i < count; ++i)
     {
       CORE_ADDR l_addr;
@@ -734,8 +737,6 @@ rocm_update_solib_list ()
       sos.emplace_back (uri_bytes, std::move (unique_name), std::move (li));
     }
 
-  xfree (code_object_list);
-
   if (rocm_solib_ops.current_sos == NULL)
     {
       /* Override what we need to.  */