From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Tue, 28 Jan 2020 10:51:50 +0000 (+0100)
Subject: ovpnmain.cgi: Validate CCDNet name when renaming it.
X-Git-Tag: v2.25-core143~59
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7ad653cc09409c4e23885bf89279bd8458189f11;p=ipfire-2.x.git

ovpnmain.cgi: Validate CCDNet name when renaming it.

Fixes #12282

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
---

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index a6fdd6d75a..ce9524df79 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -490,6 +490,13 @@ sub modccdnet
 	my $oldname=$_[1];
 	my %ccdconfhash=();
 	my %ccdhash=();
+
+	# Check if the new name is valid.
+	if(!&General::validhostname($newname)) {
+		$errormessage=$Lang::tr{'ccd err invalidname'};
+		return;
+	}
+
 	&General::readhasharray("${General::swroot}/ovpn/ccd.conf", \%ccdconfhash);
 	foreach my $key (keys %ccdconfhash) {
 		if ($ccdconfhash{$key}[0] eq $oldname) {