From: Colin Ian King Date: Tue, 10 Dec 2019 14:45:35 +0000 (+0000) Subject: drm/i915/display: remove duplicated assignment to pointer crtc_state X-Git-Tag: v5.6-rc1~114^2~17^2~116 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7b0bcead187fb3afb45fd052316f9eb967ef1986;p=thirdparty%2Flinux.git drm/i915/display: remove duplicated assignment to pointer crtc_state Pointer crtc_state is being assigned twice, one of these is redundant and can be removed. Addresses-Coverity: ("Evaluation order violation") Signed-off-by: Colin Ian King Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20191210144535.341977-1-colin.king@canonical.com --- diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index d0d37a9797374..0e5a33969d775 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -17751,7 +17751,7 @@ intel_modeset_setup_hw_state(struct drm_device *dev, for_each_intel_crtc(&dev_priv->drm, crtc) { struct intel_crtc_state *crtc_state = - crtc_state = to_intel_crtc_state(crtc->base.state); + to_intel_crtc_state(crtc->base.state); intel_sanitize_crtc(crtc, ctx); intel_dump_pipe_config(crtc_state, NULL, "[setup_hw_state]");