From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 3 Mar 2022 21:58:39 +0000 (-0800)
Subject: am/apply: warn if we end up reading patches from terminal
X-Git-Tag: v2.36.0-rc0~7^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7b20af6a069f1be1ac0354451e0edd9825b22534;p=thirdparty%2Fgit.git

am/apply: warn if we end up reading patches from terminal

In an interactive session, "git am" without arguments, or even
worse, "git am --whitespace file", waits silently for the user to
feed the patches from the standard input (presumably by typing or
copy-pasting).  Give a feedback message to the user when this
happens, as it is unlikely that the user meant to do so.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c
index 7baef30569..30952353a3 100644
--- a/builtin/mailsplit.c
+++ b/builtin/mailsplit.c
@@ -223,6 +223,9 @@ static int split_mbox(const char *file, const char *dir, int allow_bare,
 	FILE *f = !strcmp(file, "-") ? stdin : fopen(file, "r");
 	int file_done = 0;
 
+	if (isatty(fileno(f)))
+		warning(_("reading patches from stdin/tty..."));
+
 	if (!f) {
 		error_errno("cannot open mbox %s", file);
 		goto out;